Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): introduce collapsible section + harmonize collapser - WF-47 #599

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

madeindjs
Copy link
Collaborator

@madeindjs madeindjs commented Oct 19, 2024

Add collapsible option to CoreSection.

Screencast.from.2024-10-20.22-45-40.mp4

I also took the opportunity to

  • reuse some fields from CoreColumn
  • improve the A11Y using <button> instead of <div>
  • refactor the logic into a common component BaseCollapseButton to use in Column, Sidebar and Section

closes #506

@madeindjs madeindjs changed the title feat(ui): introduce collapsible section - WF-47 feat(ui): introduce collapsible section + harmonize collapser - WF-47 Oct 20, 2024
@madeindjs madeindjs marked this pull request as ready for review October 20, 2024 20:40
@ramedina86 ramedina86 merged commit 330f317 into writer:dev Oct 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapsable navigation bar
2 participants