Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prevent workflows tree to be sent during run mode - Wf 74 #581

Conversation

FabienArcellier
Copy link
Collaborator

@FabienArcellier FabienArcellier commented Oct 7, 2024

This PR adapts the communication of components to the frontend depending on the execution mode. In run mode, workflow-type components are not exposed to the backend.

@FabienArcellier FabienArcellier changed the title prevent workflows tree to be sent during run mode - Wf 74 feat: prevent workflows tree to be sent during run mode - Wf 74 Oct 7, 2024
@FabienArcellier FabienArcellier self-assigned this Oct 7, 2024
@FabienArcellier FabienArcellier changed the title feat: prevent workflows tree to be sent during run mode - Wf 74 chore: prevent workflows tree to be sent during run mode - Wf 74 Oct 7, 2024
@FabienArcellier FabienArcellier force-pushed the WF-74-prevent-workflows-tree-to-be-sent-during-run-mode branch 2 times, most recently from 4dfe04c to d577495 Compare October 8, 2024 05:53
@@ -595,7 +595,7 @@ def cumulative_sum(state):
"total": 0
})

initial_state.subscribe_mutation('a\.b', cumulative_sum)
initial_state.subscribe_mutation(r'a\.b', cumulative_sum)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It removes warning into continuous integration pipeline

@FabienArcellier FabienArcellier marked this pull request as ready for review October 8, 2024 05:56
Copy link
Collaborator

@ramedina86 ramedina86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you 🚀

@ramedina86
Copy link
Collaborator

E2E tests running for 2:30hs? I guess I'll restart them

* refact: use core_ui.export_component_tree before sending the component tree to user interface
* refact: use ServeMode as typing for all argument that requires run or edit
* fix: warning on continuous integration
* refact: add fixtures to test workflow export
* chore: implement test on filtering workflow export
@FabienArcellier FabienArcellier force-pushed the WF-74-prevent-workflows-tree-to-be-sent-during-run-mode branch from 0ff0b4e to a0a7008 Compare October 8, 2024 15:37
* create default create_default_workflows_root
* migrate e2e:presets
@FabienArcellier FabienArcellier force-pushed the WF-74-prevent-workflows-tree-to-be-sent-during-run-mode branch from a0a7008 to cc6efb9 Compare October 8, 2024 15:40
@ramedina86 ramedina86 merged commit eb547ee into writer:dev Oct 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants