-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prevent workflows tree to be sent during run mode - Wf 74 #581
Merged
ramedina86
merged 4 commits into
writer:dev
from
FabienArcellier:WF-74-prevent-workflows-tree-to-be-sent-during-run-mode
Oct 10, 2024
Merged
chore: prevent workflows tree to be sent during run mode - Wf 74 #581
ramedina86
merged 4 commits into
writer:dev
from
FabienArcellier:WF-74-prevent-workflows-tree-to-be-sent-during-run-mode
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabienArcellier
changed the title
prevent workflows tree to be sent during run mode - Wf 74
feat: prevent workflows tree to be sent during run mode - Wf 74
Oct 7, 2024
FabienArcellier
changed the title
feat: prevent workflows tree to be sent during run mode - Wf 74
chore: prevent workflows tree to be sent during run mode - Wf 74
Oct 7, 2024
FabienArcellier
force-pushed
the
WF-74-prevent-workflows-tree-to-be-sent-during-run-mode
branch
2 times, most recently
from
October 8, 2024 05:53
4dfe04c
to
d577495
Compare
FabienArcellier
commented
Oct 8, 2024
@@ -595,7 +595,7 @@ def cumulative_sum(state): | |||
"total": 0 | |||
}) | |||
|
|||
initial_state.subscribe_mutation('a\.b', cumulative_sum) | |||
initial_state.subscribe_mutation(r'a\.b', cumulative_sum) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It removes warning into continuous integration pipeline
ramedina86
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you 🚀
madeindjs
approved these changes
Oct 8, 2024
E2E tests running for 2:30hs? I guess I'll restart them |
* refact: use core_ui.export_component_tree before sending the component tree to user interface * refact: use ServeMode as typing for all argument that requires run or edit * fix: warning on continuous integration
* feat: send workflow in edit mode
* refact: add fixtures to test workflow export * chore: implement test on filtering workflow export
FabienArcellier
force-pushed
the
WF-74-prevent-workflows-tree-to-be-sent-during-run-mode
branch
from
October 8, 2024 15:37
0ff0b4e
to
a0a7008
Compare
* create default create_default_workflows_root * migrate e2e:presets
FabienArcellier
force-pushed
the
WF-74-prevent-workflows-tree-to-be-sent-during-run-mode
branch
from
October 8, 2024 15:40
a0a7008
to
cc6efb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the communication of components to the frontend depending on the execution mode. In run mode, workflow-type components are not exposed to the backend.