fix(ui): handle visibility from object prop for CoreTab. WF-73
#580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was that the tab is randomly visible when receiving Visibility setting from the state object property. The root cause is `ComponentProxy` try to apply `display: none`, but it collide with `CoreTab`'s `v-show`. The fix is simply to check the visibily in `CoreTab` to adapt `v-show` accordingly.
|
Nice investigation and fix ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that the tab is randomly visible when receiving Visibility setting from the state object property.
The root cause is
ComponentProxytry to applydisplay: none, but it collide withCoreTab'sv-show. The fix is simply to check the visibily inCoreTabto adaptv-showaccordingly.