Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): make CoreSwitchInput reactive to state change - WF-81 #574

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

madeindjs
Copy link
Collaborator

@madeindjs madeindjs commented Oct 1, 2024

We used a ref to store the state of the input and try to synchronize with useFormValueBroker. But in fact, there is no reason to do it since this method already use an optimistic update.

function handleInput(
eventValue: any,
emitEventType: string,
customCallback?: Function,
) {
formValue.value = eventValue;

Screencast.from.2024-10-01.21-48-32.mp4

@FabienArcellier
Copy link
Collaborator

implement #576

@FabienArcellier FabienArcellier changed the title fix(ui): make CoreSwitchInput reactive to state change. WF-81 fix(ui): make CoreSwitchInput reactive to state change - WF-81 Oct 2, 2024
@ramedina86 ramedina86 merged commit 25b6c2d into writer:dev Oct 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants