Skip to content

Commit

Permalink
chore(ui): improve hash parsing + test - WF-72
Browse files Browse the repository at this point in the history
It's possible to use `URLSearchParams` instead of complex Regex. As
it'sa very testable part of the code, it was a good opportunity to
introduceVitest and cover it.This improvement made me realise that a bug
was present, and we didn'tserialize the params when converting back the
object to hash (`.key =length` was not called).
  • Loading branch information
madeindjs committed Nov 28, 2024
1 parent ec53f21 commit 52909c2
Show file tree
Hide file tree
Showing 4 changed files with 495 additions and 54 deletions.
Loading

0 comments on commit 52909c2

Please sign in to comment.