Workaround GTC-2986 by checking if version is successfully created after get 5XX response from API #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter getting 5XX response
jterry64
requested review from
gtempus,
solomon-negusse,
danscales,
dmannarino and
manukala6
danscales
approved these changes
Sep 12, 2024
src/datapump/clients/data_api.py
Outdated
| uri = f"{GLOBALS.data_api_uri}/dataset/{dataset}/{version}/assets" | ||
| return self._send_request(ValidMethods.post, uri, payload)["data"] | ||
| return self.get_version(ValidMethods.post, uri, payload)["data"] |
There was a problem hiding this comment.
Was there a bad merge here? I don't see any reason to change create_aux_asset() to use get_version(), and it is the wrong set of args for get_version.
There was a problem hiding this comment.
Oh possibly, I had to backwards merge some hotfixes from master to develop that may have gotten mixed up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
We often see during nightly jobs to create new GLAD/integrated alerts tables a 500 response from the API on version creation, but the version often actually does get created. This then gives a 400 error on retry that the version already exists, and causes us to error out before finishing the sync job, even though the table was actually successfully uploaded.
What is the new behavior?
On getting error from creating new version, check if version did successfully get created before returning an exception.
Does this introduce a breaking change?
Other information