-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature version aliasing #236
Conversation
Private datasets, OOM recover
Reliability improvements and bug fixes
Merge develop to master
it takes hours so can't do it at startup
Codecov Report
@@ Coverage Diff @@
## feature/Revisions #236 +/- ##
=====================================================
- Coverage 85.87% 85.38% -0.49%
=====================================================
Files 113 118 +5
Lines 4502 4626 +124
=====================================================
+ Hits 3866 3950 +84
- Misses 636 676 +40
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
- create middleware that redirects from version alias to version for supported ops - create dependency that checks for alias conflict when creating a version
@@ -77,6 +77,37 @@ async def redirect_latest(request: Request, call_next): | |||
return response | |||
|
|||
|
|||
async def redirect_alias_to_version(request: Request, call_next): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so I understand correctly, this will check the request has /dataset/{dataset}/{version} in the path, and if so, check if it's an alias and redirect? Maybe add a doc string for this one to explain the behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly. I've updated docstring with the detail.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: 1405
What is the new behavior?
Does this introduce a breaking change?
Other information