Skip to content

Commit

Permalink
Fix a logic error with 3DS2 dismissal (stripe#3361)
Browse files Browse the repository at this point in the history
## Summary
When initiating a 3DS2 transaction, we invoked the completion block
twice. We should only invoke it once.

## Testing
CI, manually in PaymentSheet Example

## Changelog
Will add to release PR
  • Loading branch information
davidme-stripe authored Mar 4, 2024
1 parent 27c93b5 commit ed6094d
Showing 1 changed file with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -443,14 +443,12 @@ extension BottomSheetViewController: PaymentSheetAuthenticationContext {
func present(
_ authenticationViewController: UIViewController, completion: @escaping () -> Void
) {
// Remove a blur effect, if any
self.removeBlurEffect(animated: true, completion: completion)

let threeDS2ViewController = BottomSheet3DS2ViewController(
challengeViewController: authenticationViewController, appearance: appearance, isTestMode: isTestMode)
threeDS2ViewController.delegate = self
pushContentViewController(threeDS2ViewController)
completion()
// Remove a blur effect, if any
self.removeBlurEffect(animated: true, completion: completion)
}

func presentPollingVCForAction(action: STPPaymentHandlerActionParams, type: STPPaymentMethodType, safariViewController: SFSafariViewController?) {
Expand Down

0 comments on commit ed6094d

Please sign in to comment.