Pass Session ID to Link popup (stripe#3256)

## Summary Pass the analytics session ID to the Link popup ## Testing Updated URL generator test
wpkyoto · Feb 12, 2024 · e83423a · e83423a
1 parent 1ac6a10
commit e83423a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/StripePaymentSheet/StripePaymentSheet/Source/Internal/Link/Utils/LinkURLGenerator.swift b/StripePaymentSheet/StripePaymentSheet/Source/Internal/Link/Utils/LinkURLGenerator.swift
@@ -35,7 +35,7 @@ struct LinkURLParams: Encodable {
     var paymentInfo: PaymentInfo?
     var experiments: [String: Bool]
     var flags: [String: Bool]
-    var loggerMetadata: [String: Bool]
+    var loggerMetadata: [String: String]
     var locale: String
 }
 
@@ -68,6 +68,11 @@ class LinkURLGenerator {
             return nil
         }()
 
+        var loggerMetadata: [String: String] = [:]
+        if let sessionID = AnalyticsHelper.shared.sessionID {
+            loggerMetadata = ["mobile_session_id": sessionID]
+        }
+
         let paymentObjectType: LinkURLParams.PaymentObjectMode = intent.linkPassthroughModeEnabled ? .card_payment_method : .link_payment_method
 
         return LinkURLParams(paymentObject: paymentObjectType,
@@ -78,7 +83,7 @@ class LinkURLGenerator {
                              paymentInfo: paymentInfo,
                              experiments: [:],
                              flags: intent.linkFlags,
-                             loggerMetadata: [:],
+                             loggerMetadata: loggerMetadata,
                              locale: Locale.current.toLanguageTag())
     }
 

diff --git a/StripePaymentSheet/StripePaymentSheetTests/PaymentSheet/Link/LinkURLGeneratorTests.swift b/StripePaymentSheet/StripePaymentSheetTests/PaymentSheet/Link/LinkURLGeneratorTests.swift
@@ -24,7 +24,8 @@ class LinkURLGeneratorTests: XCTestCase {
                                    experiments: [:],
                                    flags: [:],
                                    loggerMetadata: [:],
-                                   locale: Locale.init(identifier: "en_US").toLanguageTag())
+                                   locale: Locale.init(identifier: "en_US").toLanguageTag()
+    )
 
     func testURLCreation() {
         let url = try! LinkURLGenerator.url(params: testParams)
@@ -56,6 +57,11 @@ class LinkURLGeneratorTests: XCTestCase {
         }
         config.apiClient.publishableKey = "pk_123"
         let intent = Intent.deferredIntent(elementsSession: STPElementsSession.emptyElementsSession, intentConfig: intentConfig)
+
+        // Create a session ID
+        AnalyticsHelper.shared.generateSessionID()
+        let sessionID = AnalyticsHelper.shared.sessionID!
+
         let params = try! LinkURLGenerator.linkParams(configuration: config, intent: intent)
 
         let expectedParams = LinkURLParams(paymentObject: .link_payment_method,
@@ -66,7 +72,7 @@ class LinkURLGeneratorTests: XCTestCase {
                                            paymentInfo: LinkURLParams.PaymentInfo(currency: "USD", amount: 100),
                                            experiments: [:],
                                            flags: [:],
-                                           loggerMetadata: [:],
+                                           loggerMetadata: ["mobile_session_id": sessionID],
                                            locale: Locale.init(identifier: "en_US").toLanguageTag())
 
         XCTAssertEqual(params, expectedParams)