Skip to content

Commit

Permalink
Uncomment CBC tests (stripe#3368)
Browse files Browse the repository at this point in the history
## Summary
Uncomment CBC Tests

## Motivation
Was only uncommented temporarily to unblock CI

## Testing
None

## Changelog
<!-- Is this a notable change that affects users? If so, add a line to
`CHANGELOG.md` and prefix the line with one of the following:
    - [Added] for new features.
    - [Changed] for changes in existing functionality.
    - [Deprecated] for soon-to-be removed features.
    - [Removed] for now removed features.
    - [Fixed] for any bug fixes.
    - [Security] in case of vulnerabilities.
-->

Co-authored-by: Nick Porter <[email protected]>
  • Loading branch information
wooj-stripe and porter-stripe authored Mar 13, 2024
1 parent f353bb2 commit 8d482a9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,6 @@ class CustomerSheetUITest: XCTestCase {
}

// MARK: - Card Brand Choice tests
/* Temporarily disable CBC tests
func testCardBrandChoiceSavedCard() {
var settings = CustomerSheetTestPlaygroundSettings.defaultValues()
settings.customerMode = .new
Expand Down Expand Up @@ -852,9 +851,8 @@ class CustomerSheetUITest: XCTestCase {
let successText = app.staticTexts["Complete"]
XCTAssertTrue(successText.waitForExistence(timeout: 10.0))
}
*/

// MARK: - allowsRemovalOfLastSavedPaymentMethod
/*
func testRemoveLastSavedPaymentMethod() throws {
var settings = CustomerSheetTestPlaygroundSettings.defaultValues()
settings.merchantCountryCode = .FR
Expand Down Expand Up @@ -915,7 +913,7 @@ class CustomerSheetUITest: XCTestCase {
// ...but should not be able to remove it.
XCTAssertFalse(app.buttons["Remove card"].exists)
}
*/

// MARK: - Helpers

func presentCSAndAddCardFrom(buttonLabel: String, cardNumber: String? = nil, tapAdd: Bool = true) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -893,7 +893,6 @@ class PaymentSheetStandardLPMUITests: PaymentSheetUITestCase {
}

// MARK: Card brand choice
/* Temporarily disable CBC tests
func testCardBrandChoice() throws {
// Currently only our French merchant is eligible for card brand choice
var settings = PaymentSheetTestPlaygroundSettings.defaultValues()
Expand Down Expand Up @@ -1096,7 +1095,7 @@ class PaymentSheetStandardLPMUITests: PaymentSheetUITestCase {
// Card should be removed
XCTAssertFalse(app.staticTexts["••••1001"].waitForExistence(timeout: 5.0))
}
*/

// This only tests the PaymentSheet + PaymentIntent flow.
// Other confirmation flows are tested in PaymentSheet+LPMTests.swift
func testSEPADebitPaymentMethod_PaymentSheet() {
Expand Down

0 comments on commit 8d482a9

Please sign in to comment.