Swap out a few more PNGs for SVGs (stripe#2989)

## Summary
* Swap out a few more assets for their vector representations.
* Move PaymentSheet Example snapshot tests to the
StripePaymentSheetTests bundle to make it easier to re-run them.
* These tests didn't work outside of a host app (as view controller
presentation seems to be broken when running directly from xctest), so
reuse the StripeiOS tests host app for StripePaymentSheet's tests.
* Regenerate relevant snapshot tests.

## Testing
CI snapshots

## Changelog
None

Example/PaymentSheet Example/PaymentSheetUITest/PaymentSheetUITest.swift

@@ -1019,7 +1019,7 @@ class PaymentSheetStandardLPMUITests: PaymentSheetUITestCase {
         app.buttons["Present PaymentSheet"].waitForExistenceAndTap(timeout: 5)
         // Saved card should show the cartes bancaires logo
         XCTAssertTrue(app.staticTexts["••••1001"].waitForExistence(timeout: 5.0))
-        XCTAssertTrue(app.images["card_cartes_bancaires"].waitForExistence(timeout: 5))
+        XCTAssertTrue(app.images["carousel_card_cartes_bancaires"].waitForExistence(timeout: 5))
 
         let editButton = app.staticTexts["Edit"]
         XCTAssertTrue(editButton.waitForExistence(timeout: 60.0))

Stripe/StripeiOSTests/STPImageLibraryTest.swift

@@ -203,6 +203,14 @@ class STPImageLibraryTestSwift: XCTestCase {
         }
     }
 
+    func testUnpaddedImageForCardBrands() {
+        for brand in STPCardBrand.allCases {
+            let image = STPImageLibrary.unpaddedCardBrandImage(for: brand)
+            // Assert image exists
+            XCTAssert(image.size != .zero)
+        }
+    }
+
     func testCVCImageForCardBrand() {
         for brand in Self.cardBrands {
             let image = STPImageLibrary.cvcImage(for: brand)

StripePaymentSheet/Project.swift

@@ -23,5 +23,6 @@ let project = Project.stripeFramework(
         ],
         includesSnapshots: true,
         usesStubs: true
-    )
+    ),
+    useHostedTestApp: true
 )

StripePaymentsUI/StripePaymentsUI/Resources/StripePaymentsUI.xcassets/CardCarousel/card_discover.imageset/Contents.json → StripePaymentSheet/StripePaymentSheet/Resources/StripePaymentSheet.xcassets/Carousel/carousel_applepay.imageset/Contents.json

@@ -1,7 +1,7 @@
 {
   "images" : [
     {
-      "filename" : "discover_light.pdf",
+      "filename" : "carousel_applepay.svg",
       "idiom" : "universal"
     },
     {
@@ -11,7 +11,7 @@
           "value" : "dark"
         }
       ],
-      "filename" : "discover_dark.pdf",
+      "filename" : "applePayDark.svg",
       "idiom" : "universal"
     }
   ],

StripePaymentSheet/StripePaymentSheet/Resources/StripePaymentSheet.xcassets/Carousel/carousel_card_amex.imageset/Contents.json

@@ -0,0 +1,22 @@
+{
+  "images" : [
+    {
+      "filename" : "americanExpressLight.svg",
+      "idiom" : "universal"
+    },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "filename" : "americanExpressDark.svg",
+      "idiom" : "universal"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  }
+}

StripePaymentSheet/StripePaymentSheet/Resources/StripePaymentSheet.xcassets/Carousel/carousel_card_cartes_bancaires.imageset/Contents.json

@@ -0,0 +1,22 @@
+{
+  "images" : [
+    {
+      "filename" : "cartesBancairesLight.svg",
+      "idiom" : "universal"
+    },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "filename" : "cartesBancairesDark.svg",
+      "idiom" : "universal"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  }
+}