Skip to content

Commit

Permalink
Remove notify step from e2e deploy (#44)
Browse files Browse the repository at this point in the history
Removes the notify step of our e2e workflow. The failures in this workflow have consistently been unrelated to the site-deploy image itself and are therefore not actionable. Instead, they indicate an issue with some other service we depend on (GitHub, Docker Hub, SSH Gateway, WPE User Portal). These services are either out of our control or are already monitored in other ways.

This also bumps the cron schedule to 1 per hour.

Bonus: gets rid of a dependency on voxmedia/github-action-slack-notify-build, which has been deprecated.
  • Loading branch information
apmatthews authored Feb 6, 2025
1 parent f1afd55 commit 3c21590
Showing 1 changed file with 1 addition and 16 deletions.
17 changes: 1 addition & 16 deletions .github/workflows/e2e-deploy.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Test e2e Deploy to WP Engine
on:
schedule:
- cron: '*/5 * * * *'
- cron: '*/60 * * * *'
push:
branches:
- main
Expand Down Expand Up @@ -41,18 +41,3 @@ jobs:
- name: Validate deploy results
run: |
[ ${{ fromJson(steps.fetchResult.outputs.response).status }} = "success" ] || exit 1
notify:
runs-on: ubuntu-latest
if: ${{ !cancelled() }}
needs: run_action
steps:
- name: Notify slack on failure
if: needs.run_action.result == 'failure' && github.ref == 'refs/heads/main'
env:
SLACK_BOT_TOKEN: ${{ secrets.SLACK_NOTIFICATIONS_BOT_TOKEN }}
uses: voxmedia/github-action-slack-notify-build@v1
with:
# Channel: status-site-deploy
channel_id: C04ELD8NMT4
status: FAILED
color: danger

0 comments on commit 3c21590

Please sign in to comment.