This repository was archived by the owner on Jan 6, 2025. It is now read-only.
MTKA-1542: Ensure relationship fields resolve if model slug mismatches singular label #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindctrl
approved these changes
Jun 13, 2022
rfmeier
approved these changes
Jun 14, 2022
anthonyburchell
approved these changes
Jun 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix for #552 so that relationship fields no longer resolve as null if the model slug does not match the singular label.
https://wpengine.atlassian.net/browse/MTKA-1542
Checklist
I have:
Testing
Includes unit test for a GraphQL query with a relationship field on a model with a mismatched singular name and slug.
To test manually, import this blueprint with pre-made relationship fields and connected entries:
Then make GraphQL queries against the
modela,modelb,modelcandmismatchpost types. You should see data for the relationship fields instead of 'null'.Screenshots