Merge pull request #153 from thrijith/issue/150

Add escaping for block title
wp-cli · Jun 4, 2018 · e0e6a83 · e0e6a83
2 parents 3c1d0e2 + 1e6def6
commit e0e6a83
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/Scaffold_Command.php b/src/Scaffold_Command.php
@@ -274,8 +274,9 @@ public function block( $args, $assoc_args ) {
 		);
 		$data     = $this->extract_args( $assoc_args, $defaults );
 
-		$data['slug']          = $slug;
-		$data['title_ucfirst'] = ucfirst( $data['title'] );
+		$data['slug']             = $slug;
+		$data['title_ucfirst']    = ucfirst( $data['title'] );
+		$data['title_ucfirst_js'] = esc_js( $data['title_ucfirst'] );
 
 		$dashicon = $this->extract_dashicon( $assoc_args );
 		if ( $dashicon ) {

diff --git a/templates/block-index-js.mustache b/templates/block-index-js.mustache
@@ -24,7 +24,7 @@
 		 * This is the display title for your block, which can be translated with `i18n` functions.
 		 * The block inserter will show this name.
 		 */
-		title: __( '{{title_ucfirst}}' ),
+		title: __( '{{title_ucfirst_js}}' ),
 
 		{{#dashicon}}
 		/**