Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input macro #323

Merged
merged 5 commits into from
Jul 23, 2024
Merged

input macro #323

merged 5 commits into from
Jul 23, 2024

Conversation

woylie
Copy link
Owner

@woylie woylie commented Jul 23, 2024

  • turn input into macro
  • remove obsolete components
  • update input story
  • pass gettext module as build option
  • make classes configurable

@woylie woylie enabled auto-merge July 23, 2024 05:05
@woylie woylie merged commit 0466338 into main Jul 23, 2024
8 checks passed
@woylie woylie deleted the input-macro branch July 23, 2024 05:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 633a6ee2f70d81ef87dd523cfc2f4cb6ae677952-PR-323

Details

  • 40 of 44 (90.91%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.5%) to 82.217%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/doggo/macros.ex 2 4 50.0%
lib/doggo/storybook/input.ex 6 8 75.0%
Files with Coverage Reduction New Missed Lines %
lib/doggo.ex 2 96.59%
Totals Coverage Status
Change from base Build 32aad7889a9648b5c0f38976fe53cf1470c78427: -2.5%
Covered Lines: 675
Relevant Lines: 821
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woylie @coveralls