chore(model): only create skeleton if model needs skinning

wowserhq · Jan 30, 2024 · ee57a0c · ee57a0c
1 parent 89ba316
commit ee57a0c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/lib/model/ModelAnimation.ts b/src/lib/model/ModelAnimation.ts
@@ -45,7 +45,9 @@ class ModelAnimation extends THREE.Object3D {
     this.#playingActions.clear();
     this.#suspendedActions.clear();
 
-    this.skeleton.dispose();
+    if (this.skeleton) {
+      this.skeleton.dispose();
+    }
   }
 
   resume() {
@@ -88,6 +90,10 @@ class ModelAnimation extends THREE.Object3D {
   }
 
   #createSkeleton(boneSpecs: BoneSpec[]) {
+    if (boneSpecs.length === 0) {
+      return;
+    }
+
     const bones: THREE.Bone[] = [];
     const rootBones: THREE.Bone[] = [];
 

diff --git a/src/lib/model/ModelManager.ts b/src/lib/model/ModelManager.ts
@@ -217,7 +217,7 @@ class ModelManager {
       return null;
     }
 
-    const animator = new ModelAnimator(spec.loops, spec.sequences, spec.bones);
+    const animator = new ModelAnimator(spec.loops, spec.sequences, spec.skinned ? spec.bones : []);
 
     for (const [index, textureWeight] of spec.textureWeights.entries()) {
       animator.registerTrack(