Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest node version and few small fixes #109

Merged
merged 5 commits into from
Aug 18, 2018
Merged

Latest node version and few small fixes #109

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3dac9b3
Add support for node 9 & 10
avengerweb Aug 11, 2018
d1e87c9
Add .idea (webstorm) directory to gitignore
avengerweb Aug 11, 2018
f160665
Make glob case insensitive - fix working on unix like OS
avengerweb Aug 11, 2018
33f4db1
Update readme, missed dependency for StormLib build
avengerweb Aug 11, 2018
246668e
Added newlines in readme, remove $ from code snippets
avengerweb Aug 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@
/node_modules/
/spec/**/*.js
*.dll
.idea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an editor specific ignore and should be in your global configuration (https://help.github.com/articles/ignoring-files/#create-a-global-gitignore and https://help.github.com/articles/ignoring-files/#explicit-repository-excludes)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

5 changes: 4 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
sudo: required
language: node_js
node_js:
- '4'
- '5'
- '6'
- '7'
- '8'
- '9'
- '10'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

matrix:
fast_finish: true
addons:
Expand Down
20 changes: 20 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,16 @@ to `libblp.dll` and ensure it ends up on the load PATH.
By default, node-gyp compiles ffi for x64 so make sure `libblp.dll`
matches this architecture.

#### Ubuntu, Debian
```shell
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a newline between the heading and the code snippet?

$ sudo apt-get install cmake git gcc
$ git clone git://github.com/Kanma/BLPConverter.git
$ cd BLPConverter
$ cmake CMakeLists.txt -DWITH_LIBRARY=YES
$ sudo make install
$ sudo ldconfig
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to finally have this in place, thanks! It'll resolve issue #88.

Could you remove the $-indicator on each line so that it can be easily copy pasted?


#### Other platforms

Compile from source and ensure the library ends up on the load path.
Expand Down Expand Up @@ -190,6 +200,16 @@ rename `StormLib.dll` to `libstorm.dll` and ensure it ends up on the load PATH.
By default, node-gyp compiles ffi for x64 so make sure `libstorm.dll`
matches this architecture.

#### Ubuntu, Debian
```shell
$ sudo apt-get install cmake git gcc zlib1g-dev
$ git clone git://github.com/ladislav-zezula/StormLib.git
$ cd StormLib
$ cmake CMakeLists.txt -DBUILD_SHARED_LIBS=ON
$ sudo make install
$ sudo ldconfig
```

#### Other platforms

Compile from source and ensure the library ends up on the load path.
Expand Down
Loading