-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add identityManager v3 with modified verifyProof impl #164
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to also expose a verifyCompressedProof
function that can just take as calldata the compressed proof in the upgrade?
Seems like a good idea I think. |
187a731
to
0115c67
Compare
2570455
to
bb48d8a
Compare
Context:
We are looking at ways to reduce the calldata posted from World Chain -> l1 blobs/calldata to reduce cost and increase scalability. A large percentage of World Chain transactions have a ZKP which can be compressed from 8 uints to 4 uints. The Sempahore Verifier contract has a
verifyCompressedProof
function that can be called directly. We want to create a backwards compatible way to reduce the proof size as well as introduce an explicit function for verifying compressed proofs. We make this backwards compatible by checking the last four uints, if they are all 0 we can assume this proof is compressed and we should call the appropriate function. The addeded verifyCompressedProof should be used in all new smart contracts.Changes
SempahoreVerifier.verifyCompressedProof
Deployment
upgradeTo
on WorldIDIdentityManager