Ps/buckets config improvements #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsippl
added a commit
that referenced
this pull request
Jan 28, 2025
* start to add code for bucket comparison * progress on buckets * . * . * . * . * . * send/receive u32 with chacah encryption * bitinject * compare multiple thresholds function done, untested * also make <= * fix: Also fix the threshold comparison * wip: keep results around * wip * clippy * wip * fix: ignore phantom matchers * wip * wip * fix: wrong kernel for assign_u32 function * fix: use correct buffer in buckets-GPU function * feat: adapt threshold test for new test strucuture * minor fix * . * another testcase adapted * another testcase adapted * . * another testcase adapted * . * another testcase adapted * . * . * add new test case for bucketing * . * . * fix an error * add another test * . * add buckets test * . * . * wip * use the open_bucket function in the testcase * . * make open_buckets not overwrite input * function for threshold translation * . * match_distances_counter_idx * minor * fix an int/size_t error for kernels! * sort results for consistency across nodes * clean + clippy * cleanup and fixes * clippy * remove keeping two results around * up * add synchronize streams after loading to GPU in gpu_dependant testcases * clippy fix * debug for testcases * . * . * fix the len issues in sending/receiving * fix of fix * remove or-tree test * fix? * buckets as config * Ps/buckets config improvements (#965) * buckets as config * stage config * revert nccl changes * custom image build * custom image deployment * await streams * prod config * clippy * revert staging deployment --------- Co-authored-by: Roman Walch <[email protected]> Co-authored-by: Carlo Mazzaferro <[email protected]> Co-authored-by: Carlo Mazzaferro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.