Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port local copy of HawkSearcher for application-specific customizations #898

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Port local copy of HawkSearcher for application-specific customizations #898

merged 4 commits into from
Jan 10, 2025

Conversation

bgillesp
Copy link
Collaborator

@bgillesp bgillesp commented Jan 9, 2025

Creates a local copy of the HawkSearcher data structure that can be used for algorithm customizations specific to our MPC setting. Local version is called just HnswSearcher to distinguish it from the HawkPack version, and to make the class more legible to anyone reading the codebase with less context.

@bgillesp bgillesp requested a review from iliailia January 9, 2025 21:59
iliailia
iliailia approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@iliailia iliailia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left a few minor comments.

@github-actions github-actions bot added the chore label Jan 10, 2025
@bgillesp bgillesp merged commit 50c9bdd into main Jan 10, 2025
13 checks passed
@bgillesp bgillesp deleted the bg/port-hawk-searcher branch January 10, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliailia iliailia iliailia approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgillesp @iliailia