-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anonymized stats through buckets #878
Open
philsippl
wants to merge
74
commits into
main
Choose a base branch
from
ps/buckets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 47 commits
Commits
Show all changes
74 commits
Select commit
Hold shift + click to select a range
28d1b06
start to add code for bucket comparison
rw0x0 2613064
progress on buckets
rw0x0 dc72804
.
rw0x0 e6d9d75
.
rw0x0 f71d428
.
rw0x0 0c3ff87
.
rw0x0 363248a
.
rw0x0 82ea801
send/receive u32 with chacah encryption
rw0x0 538d954
bitinject
rw0x0 03f7cd8
compare multiple thresholds function done, untested
rw0x0 9e03c3e
also make <=
rw0x0 2926cdd
fix: Also fix the threshold comparison
rw0x0 dfc60d7
Merge branch 'main' of github.com:worldcoin/gpu-iris-mpc into rw/buckets
philsippl 64a3fe4
wip: keep results around
philsippl 9bf5c6d
wip
philsippl 70bce2e
clippy
philsippl 0f26aa5
wip
philsippl c2ba1eb
fix: ignore phantom matchers
philsippl 05528e5
wip
philsippl 0b9a511
wip
philsippl 2db44f3
fix: wrong kernel for assign_u32 function
rw0x0 e29473b
fix: use correct buffer in buckets-GPU function
rw0x0 c9c60a2
feat: adapt threshold test for new test strucuture
rw0x0 4d26e4e
minor fix
rw0x0 5769bef
.
rw0x0 5a9d060
another testcase adapted
rw0x0 2219f0d
another testcase adapted
rw0x0 d664b18
.
rw0x0 0f9e401
another testcase adapted
rw0x0 1b54a0b
.
rw0x0 7a902ec
another testcase adapted
rw0x0 b35c61a
.
rw0x0 58f6b5b
.
rw0x0 20b2cd6
add new test case for bucketing
rw0x0 ec1235d
.
rw0x0 63bbc11
.
rw0x0 784747a
fix an error
rw0x0 6679731
add another test
rw0x0 7c5dbed
.
rw0x0 92bcd5e
add buckets test
rw0x0 2aa8920
.
rw0x0 87357cc
.
rw0x0 d9c4c7e
wip
philsippl 6dcc548
use the open_bucket function in the testcase
rw0x0 6a38c93
.
rw0x0 ea3eff4
make open_buckets not overwrite input
rw0x0 2370a6d
function for threshold translation
rw0x0 766ed20
.
rw0x0 611f058
match_distances_counter_idx
philsippl 599d06f
minor
rw0x0 ceff1c1
fix an int/size_t error for kernels!
rw0x0 a4fd3fe
sort results for consistency across nodes
philsippl e09fc46
clean + clippy
philsippl 0f64f36
cleanup and fixes
philsippl ca5cea0
clippy
philsippl 4cfc360
remove keeping two results around
philsippl e40dc40
Merge branch 'main' of https://github.com/worldcoin/iris-mpc into ps/…
philsippl 09b8643
up
philsippl 802dacf
add synchronize streams after loading to GPU in gpu_dependant testcases
rw0x0 da60df6
clippy fix
rw0x0 a15e9ac
debug for testcases
rw0x0 fd6d3ec
.
rw0x0 0d6be5d
.
rw0x0 db43027
fix the len issues in sending/receiving
rw0x0 239be6f
fix of fix
rw0x0 03ef5c8
remove or-tree test
rw0x0 1681616
fix?
rw0x0 dff640c
buckets as config
carlomazzaferro a2c9626
Ps/buckets config improvements (#965)
carlomazzaferro 7d61283
merge main
carlomazzaferro 4d15e1a
Merge branch 'ps/buckets' of github.com:worldcoin/iris-mpc into ps/bu…
carlomazzaferro fad8d51
revert nccl changes
carlomazzaferro f33fdf4
custom image build
carlomazzaferro 4d28ac6
custom image deployment
carlomazzaferro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need the fork again? Also if we need it this should probably be pinned to a "rev"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The macro only defines up to 12 parameters: https://github.com/coreylowman/cudarc/blob/e768643c98ba0f62e0e1eb954a5bc3ea52c2b825/src/driver/safe/launch.rs#L356-L359
I've instead switched to the underlying implementation, but needed to export the function for that: worldcoin/cudarc-fork@b6ba8da
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could just push upstream an impl with more params as a quick hack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a PR in cudarc that extends this to 20