make batch size configurable #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkales
requested changes
Sep 6, 2024
iris-mpc-gpu/src/server/sync_nccl.rs
Outdated
| const SERIAL_SIZE: usize = 16384; | ||
| pub const MAX_REQUESTS: usize = 256 * 2; | ||
| const MAX_REQUEST_ID_LEN: usize = 36; // uuidv4 string | ||
| const SERIAL_SIZE: usize = MAX_REQUESTS * MAX_REQUEST_ID_LEN; |
There was a problem hiding this comment.
I think this is not enough since we use serde_json?
There was a problem hiding this comment.
replaced the json now with bincode, now we can calculate max sizes safely
iris-mpc-gpu/src/server/sync_nccl.rs
Outdated
| @@ -72,7 +72,7 @@ mod tests { | |||
| // My state. | |||
| let state = SyncState { | |||
| db_len: 123, | |||
| deleted_request_ids: vec!["A".repeat(MAX_REQUEST_ID_LEN); MAX_REQUESTS], | |||
| deleted_request_ids: vec!["A".repeat(MAX_REQUEST_ID_LEN); 128], | |||
There was a problem hiding this comment.
I think the point of this test is to really check that the worst-case serialization size fits into the above buffer size
There was a problem hiding this comment.
yeah let me add this MAX_REQUESTS here again
There was a problem hiding this comment.
also the max len gets overwritten here? probably not what is wanted
… ps/feat/config-batch-size
dkales
approved these changes
Sep 6, 2024
… ps/feat/config-batch-size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we will start with a DB that fits in memory and only a bit later have one that doesn't fit anymore, we'll also need to update the batchsize during operations (from 64 to 256). This now makes this only a config change.