-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FL 워들제출합니다. #5
Open
Flamme1004K
wants to merge
34
commits into
woowahan-pjs:main
Choose a base branch
from
Flamme1004K:flamme1004K
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+662
−0
Open
FL 워들제출합니다. #5
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
190ac26
docs : 요구사항 정리
337557e
feat(Tile.kt): Tile에는 문자가 들어간다.
9e6149d
feat(Tile.kt): 알파벳만 입력이 가능하다.
f697439
docs : Tile의 구현 방식 변경으로 인한 요구사항 정의 변경
f5d8d6d
feat(Tile.kt) : Tile과 Tile은 비교할 수 있다.
8771abc
feat(Tiles.kt) : 5개의 Tile을 구성할 수 있는 Tiles 구현
862eb7e
feat(Tiles.kt) : Tiles는 5글자를 받는다.
b84dc75
docs : Answer에 대한 정의
ac876f8
feat(Answer.kt) : Answer는 5개의 Tile로 구성이 되어있다.
8c1daf1
feat(Answer.kt) : Answer는 5글자를 받는다.
6a25262
feat(Answer.kt, Tiles.kt): 정답과 비교하여 같은 위치에 있으면 GREEN이다
ee13936
feat(Answer.kt, Tiles.kt): 정답에는 있지만 위치가 다르면 노란색
18d8b9f
feat(Answer.kt, Tiles.kt): 아예 없으면 회색
8ca253b
feat(Answer.kt): 정답에 있는 타일은 n개이지만, 입력한 타일은 n + 1개 이상인 경우 초록 -> 노란색 ->…
7f95066
refact : 매직넘버 제거
44a0e0d
refact : MatchResult 도메인 명칭으로 변경
56b4cd9
feat(MatchResults.kt) : MatchResult 일급컬렉션 구현
d8b6671
feat(Game.kt) : 기회는 총 6번이 있다.
d0ffc16
feat(Game.kt) : 정답을 적으면 게임이 끝난다.
f4d6b61
feat(Game.kt) : 결과를 전달할 수 있다.
08ee075
feat(Game.kt) : 존재하지 않는 단어이면 재입력을 한다.
f775ac7
feat(Game.kt) : 정답과 답안은 words.txt 에 있고, 날짜가 바뀔 때 마다 답이 바뀐다.
8271db1
feat(DefaultOutput.kt) : 기본 아웃풋 추가
5f72da9
refact(ALL) : 전체적인 린트 적용 및 리팩터링
d9cefda
chore() : lint 검사
Flamme1004K 9b74d70
refactor : Game 클래스의 input, ouput 침투 로직 리팩토링
Flamme1004K dde9105
refactor(DefaultInput.kt) : readln으로 변경
Flamme1004K 24ff1f6
chore : lint 검사
Flamme1004K 3da26d3
refactor(WordsPool.kt) : WordsPool 리팩토링
Flamme1004K e0d8ff7
refactor(Input.kt, Output.kt) : fun interface로 변경
Flamme1004K 8ba25c6
refactor(words.kt) : wordsRepository -> words 변경 및 file 로직 수정
Flamme1004K 41ef174
refactor(WordleController.kt, Game.kt, MatchResults) : TryCount Excep…
Flamme1004K 0d77637
test(AnswerTest.kt) : AnswerTest를 JunitTest에서 KoTest로 변경
Flamme1004K b844aea
test(GameTest.kt) : GameTest를 JunitTest에서 KoTest로 변경
Flamme1004K File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test(AnswerTest.kt) : AnswerTest를 JunitTest에서 KoTest로 변경
commit 0d7763787ad8635d2a5fb2386eba6ab5479f042a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 컨텍스트가 답안 컨텍스트와 동일한 레벨로 구성되어있는데요.
정상적인 답안 Answer 컨텍스트 내부 -> 입력 받은 타일 비교로 구성하면
테스트 가독성이 더 좋아질 것같습니다.