-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4기][3주차] Wordle 과제 제출 - 알렉스 #18
base: main
Are you sure you want to change the base?
Conversation
* checkResult -> resultBlocks * res -> block
WordleGame 입력값 유효성 검사를 추가
Co-authored-by: SeungYoung Oh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요 알렉스님.
일단 1차로 리뷰를 해봤는데 코드 순서대로 보면서 했더니 중복되는 것도 있고
이후의 커밋에서 반영하신 것도 있고 하네요... 리뷰 어렵네요 ㅠㅠ
리뷰할게 더 보이게되면 그때 다시 댓글 달겠습니다 ㅎㅎ
src/main/java/woowaapplication/pair/game/wordle/WordleGameController.java
Outdated
Show resolved
Hide resolved
src/main/java/woowaapplication/pair/game/wordle/WordleGameController.java
Outdated
Show resolved
Hide resolved
src/main/java/woowaapplication/pair/game/wordle/WordleGame.java
Outdated
Show resolved
Hide resolved
src/main/java/woowaapplication/pair/game/wordle/WordleGameUI.java
Outdated
Show resolved
Hide resolved
src/main/java/woowaapplication/pair/game/wordle/WordleGame.java
Outdated
Show resolved
Hide resolved
src/main/java/woowaapplication/pair/game/wordle/WordleGame.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 세세하게 해주셔서 감사합니다 ㅎㅎ
피드백 반영하다가, 기존 구조가 좀 마음에 안들어서 Service 코드를 다이어트시키고 일급 컬렉션 객체인 AnswerKeyword 를 추가하여 관련 기능을 모두 응집시켜봤습니다 :)
또 같이 토론할 거리나, 이상해보이는 코드가 있다면 편하게 말씀해주시면 감사하겠습니다!! 🙇🏻♂️🙇🏻♂️
src/main/java/woowaapplication/pair/game/wordle/WordleGame.java
Outdated
Show resolved
Hide resolved
src/main/java/woowaapplication/pair/game/wordle/WordleGameService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리팩토링 잘 하셨네요!
페어프로그래밍
후기