[유안] 3단계 - HTTP 웹 서버 구현 미션 제출합니다. #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dave915
suggested changes
Nov 23, 2020
Comment on lines
+24
to
+26
| public void invalidate() { | ||
| attributes.clear(); | ||
| } |
There was a problem hiding this comment.
session의 invalidate 메소드가 호출된 후에는 해당 세션은 사용하지 못하는 것으로 알고 있어요.
아래 링크 한번 읽어보시고, 한번 검색해보시면 좋을 것 같아요 :)
| import java.util.stream.Stream; | ||
|
|
||
| public class HttpSessionStorage { | ||
| private static Map<UUID, HttpSession> sessions = new HashMap<>(); |
There was a problem hiding this comment.
sessions 에는 여러 Request Thread가 동시에 접근 가능하기 때문에
HashMap 보단 ConcurrentHashMap 이 Thread Safe 할 것 같아요 :)
| import java.util.Arrays; | ||
| import java.util.List; | ||
|
|
||
| public class AuthFilter implements Filter { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
범블비와 페어로 진행 후 제출을 잊고 있었습니다 죄송합니다
범블비의 pr과 완전히 동일합니다
그동안 했던 것 처럼 범블비 pr에 남기신 리뷰를 참고해서 같이 진행해도 될까요?