[렉스] 2단계: 연관 관계 매핑 #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woowahan-neo
requested changes
Jul 26, 2022
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| public interface AnswerRepository extends JpaRepository<Answer, Long> { | |||
|
|
|||
| List<Answer> findByQuestionIdAndDeletedFalse(Long questionId); | |||
| List<Answer> findByQuestionAndDeletedFalse(Long questionId); | |||
There was a problem hiding this comment.
Suggested change
| List<Answer> findByQuestionAndDeletedFalse(Long questionId); | |
| List<Answer> findByQuestionIdAndDeletedFalse(Long questionId); |
매개변수와 메서드명이 다르네요.
There was a problem hiding this comment.
네오 아무리 수정을 해보려해도 findByQuestionIdAndDeletedFalse라는 이름으로 변경을 하면 오류가 발생하더라고요ㅠ 다른 크루들의 코드와 비교하여도 Answer 도메인의 필드명과 메서드 명이 같은데 오류를 가 발생하는 이유를 잘 모르겠습니다ㅠ
Comment on lines
33
to
45
| User savedUser1, savedUser2; | ||
| Question savedQuestion1, savedQuestion2; | ||
|
|
||
| @BeforeEach | ||
| void setUp() { | ||
| savedUser1 = userRepository.save(JAVAJIGI); | ||
| Question Q1 = new Question("title1", "contents1", savedUser1); | ||
| savedQuestion1 = questionRepository.save(Q1); | ||
|
|
||
| savedUser2 = userRepository.save(SANJIGI); | ||
| Question Q2 = new Question("title2", "contents2", savedUser2); | ||
| savedQuestion2 = questionRepository.save(Q2); | ||
| } |
There was a problem hiding this comment.
테스트 코드도 유지보수 대상입니다.
AnswerRepositoryTest의 인스턴스 변수가 많아지면서 테스트의 가독성이 많이 안좋아졌네요.
해당 값들이 꼭 인스턴스 변수로 필요할지 고민 후 가독성을 높일 수 있는 방법에 대해 고민해보아요.
There was a problem hiding this comment.
각각의 테스트 코드 내에서 반복적으로 처리되는 로직때문에 인스턴스 변수와 BeforeEach를 만들었었는데 리펙터링을 통해 인스턴스 변수 제거 및 중복로직 제거를 해봤습니다😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 제이슨
프로젝트를 하다보니 늦게 제출하게 됐습니다ㅠㅠ
죄송합니다
이번 리뷰도 잘 부탁드립니다!!