Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 스타카토 웹 메인 페이지 생성 #576 #577

Merged
merged 8 commits into from
Jan 15, 2025
Merged

feat: 스타카토 웹 메인 페이지 생성 #576 #577

merged 8 commits into from
Jan 15, 2025

Conversation

BurningFalls
Copy link
Contributor

⭐️ Issue Number

🚩 Summary

  • 스타카토 홈페이지 제작

🛠️ Technical Concerns

🙂 To Reviewer

📋 To Do

@BurningFalls BurningFalls added backend We are backend>< feat 기능 (새로운 기능) labels Dec 30, 2024
@BurningFalls BurningFalls added this to the sprint-7 milestone Dec 30, 2024
@BurningFalls BurningFalls self-assigned this Dec 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 30, 2024 •
edited
Loading

Test Results

 25 files   25 suites   6s ⏱️
164 tests 164 ✅ 0 💤 0 ❌
171 runs  171 ✅ 0 💤 0 ❌

Results for commit 967414c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 30, 2024 •
edited
Loading

🌻Test Coverage Report

Overall Project 77.81% -0.05% 🍏
Files changed 60% ❌

File Coverage
HomeController.java 60% -40% ❌

@BurningFalls BurningFalls requested review from Junyoung-WON, Ho-Tea, linirini, hxeyexn, devhoya97 and s6m1n and removed request for devhoya97 December 30, 2024 12:05
Ho-Tea
Ho-Tea approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@Ho-Tea Ho-Tea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안드 선생님들이 디자인 피드백을 주실 것 같으니... EOF 관련 리뷰만 남겼어요!
고생하셨습니다 폭포!!
너무 잘만든것 같은데요..👍

backend/src/main/resources/static/style.css Outdated
padding: 1rem; /* 최소 패딩 */
font-size: 0.875rem; /* 가장 작은 글씨 크기 */
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개행 추가해야 할 것 같아요!

참고 블로그

backend/src/main/java/com/staccato/web/HomeController.java

@GetMapping("/")
public String index() {
return "index";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

옛날 기억이 새록새록하네요....🙃

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

록새록새..

linirini
linirini approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@linirini linirini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제 눈에는 좋아 보여요 ><

hxeyexn
hxeyexn approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@hxeyexn hxeyexn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

폭포 고생 많으셨습니다~ 👍
사소한 코멘트 하나 남겨두었습니다!!

backend/src/main/resources/static/images/home/0.png Outdated
Copy link
Contributor

@hxeyexn hxeyexn Jan 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아래 사진이 없는 게 좀 더 깔끔할 것 같은데 빙티랑 호두 생각은 어떠신가용?
image

@s6m1n
@Junyoung-WON

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뭐랄까, 데모데이 페이지는 스크롤에 하면서 흰색 배경의 그라데이션이 서서히 잡아먹는(?) 느낌의 애니메이션이 있어서
위 화면을 첫번째 화면으로 두었지만
지금 구현된 페이지는 그런 애니메이션이 없고, 적용하는 것도 수고스러울 것 같아요!

배경 색을 흰 색으로 변경하면 좀 더 자연스러워 보일 것 같고,
아니면 이어지는 페이지에서 앱 로고와 소개를 함께 보여주고 있으니까 해당 페이지는 삭제해도 괜찮을 것 같아요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

처음 페이지 삭제 완료했습니다!

Junyoung-WON
Junyoung-WON approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@Junyoung-WON Junyoung-WON left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
메인 웹 페이지까지 만들어주시다니 너무 감사하고 수고했습니다!
풀스택 개발자 폭포를 응원합니다 💪

크게 수정할 부분은 없는 것 같아서 Approve 드립니다! 첫번째 페이지에 대해 코멘트 하나 남겨놨으니 확인만 부탁드려요~

backend/src/main/resources/templates/index.html

<!-- Footer -->
<footer>
<p>&copy; 2025 Staccato. All rights reserved.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분 뭔가 멋있네요. ㅋㅋㅋㅋ🤣

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

footer 국룰 멘트더라구요 따라해봤습니다 ㅋㅋㅋㅋ

backend/src/main/resources/static/images/index/1.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다시 자세히 확인해보니 각 화면 별 디자인이 조오금 다른 부분이 보이네요...!

  • 기분이들 디자인이 초기 디자인
  • 지도 위의 마커 디자인이 초기 디자인

너무 사소해서 크게 신경쓸 부분도 아니고 당장 수정해야하는 것도 아닌 것 같아서,
그냥 넘어가도 되지 않을까...ㅋㅋㅋ 생각합니다.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

사진에서 보이는 것처럼 마커와 기분이들이 초기 디자인이에요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피그마에 있는 사진들 그대로 집어넣은거라서, 혹시 디자인 변경해서 알려주시면 바꿔서 집어넣도록 하겠습니다!

s6m1n
s6m1n approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@s6m1n s6m1n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

폭포 너무 수고하셨습니다!
혹시 프론트 개발자들 실직하는 소리가 제 귀에만 들리나요? (조크)
너무 잘 만들어주셔서 얼른 앱에 연결해버리고 싶네요 ~~

@BurningFalls BurningFalls merged commit 180ac94 into develop Jan 15, 2025
5 checks passed
@BurningFalls BurningFalls deleted the feature/#576-make-homepage branch January 15, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Junyoung-WON Junyoung-WON Junyoung-WON approved these changes

@s6m1n s6m1n s6m1n approved these changes

@Ho-Tea Ho-Tea Ho-Tea approved these changes

@linirini linirini linirini approved these changes

@hxeyexn hxeyexn hxeyexn approved these changes

Assignees

@BurningFalls BurningFalls

Labels
backend We are backend>< feat 기능 (새로운 기능)
Projects
2024-staccato
Status: Done
Milestone
sprint-7
Development

Successfully merging this pull request may close these issues.
6 participants
@BurningFalls @s6m1n @Junyoung-WON @Ho-Tea @linirini @hxeyexn