Skip to content

Commit

Permalink
refactor: Batch 네이밍 Bulk로 변경
Browse files Browse the repository at this point in the history
  • Loading branch information
Ho-Tea committed Jan 12, 2025
1 parent ee72d70 commit 7c66f2d
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ public interface CommentRepository extends JpaRepository<Comment, Long> {

@Modifying
@Query("DELETE FROM Comment c WHERE c.moment.id IN :momentIds")
void deleteAllByMomentIdInBatch(@Param("momentIds") List<Long> momentIds);
void deleteAllByMomentIdInBulk(@Param("momentIds") List<Long> momentIds);
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ public interface MemoryMemberRepository extends JpaRepository<MemoryMember, Long

@Modifying
@Query("DELETE FROM MemoryMember mm WHERE mm.memory.id = :memoryId")
void deleteAllByMemoryIdInBatch(@Param("memoryId") Long memoryId);
void deleteAllByMemoryIdInBulk(@Param("memoryId") Long memoryId);
}
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,9 @@ private void deleteAllRelatedMemory(long memoryId) {
.map(Moment::getId)
.toList();
momentImageRepository.deleteAllByMomentIdInBulk(momentIds);
commentRepository.deleteAllByMomentIdInBatch(momentIds);
momentRepository.deleteAllByMemoryIdInBatch(memoryId);
memoryMemberRepository.deleteAllByMemoryIdInBatch(memoryId);
commentRepository.deleteAllByMomentIdInBulk(momentIds);
momentRepository.deleteAllByMemoryIdInBulk(memoryId);
memoryMemberRepository.deleteAllByMemoryIdInBulk(memoryId);
}

private void validateOwner(Memory memory, Member member) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ public interface MomentRepository extends JpaRepository<Moment, Long> {

@Modifying
@Query("DELETE FROM Moment m WHERE m.memory.id = :memoryId")
void deleteAllByMemoryIdInBatch(@Param("memoryId") Long memoryId);
void deleteAllByMemoryIdInBulk(@Param("memoryId") Long memoryId);
}
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ private Memory getMemoryById(long memoryId) {
public void deleteMomentById(long momentId, Member member) {
momentRepository.findById(momentId).ifPresent(moment -> {
validateMemoryOwner(moment.getMemory(), member);
commentRepository.deleteAllByMomentIdInBatch(List.of(momentId));
commentRepository.deleteAllByMomentIdInBulk(List.of(momentId));
momentImageRepository.deleteAllByMomentIdInBulk(List.of(momentId));
momentRepository.deleteById(momentId);
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class CommentRepositoryTest {

@DisplayName("특정 스타카토의 id를 여러개를 가지고 있는 모든 댓글들을 삭제한다.")
@Test
void deleteAllByMomentIdInBatch() {
void deleteAllByMomentIdInBulk() {
// given
Member member = memberRepository.save(MemberFixture.create());
Memory memory = memoryRepository.save(MemoryFixture.create(null, null));
Expand All @@ -47,7 +47,7 @@ void deleteAllByMomentIdInBatch() {
momentRepository.save(moment2);

// when
commentRepository.deleteAllByMomentIdInBatch(List.of(moment1.getId(), moment2.getId()));
commentRepository.deleteAllByMomentIdInBulk(List.of(moment1.getId(), moment2.getId()));
em.flush();
em.clear();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ void findAllByMemberIdAndDateWhenNull() {

@DisplayName("특정 추억의 id를 가지고 있는 모든 MemoryMember를 삭제한다.")
@Test
void deleteAllByMemoryIdInBatch() {
void deleteAllByMemoryIdInBulk() {
// given
Member member = memberRepository.save(MemberFixture.create());
Member member2 = memberRepository.save(MemberFixture.create("hotea"));
Expand All @@ -91,7 +91,7 @@ void deleteAllByMemoryIdInBatch() {
MemoryMember memoryMember2 = memoryMemberRepository.save(new MemoryMember(member2, memory));

// when
memoryMemberRepository.deleteAllByMemoryIdInBatch(memory.getId());
memoryMemberRepository.deleteAllByMemoryIdInBulk(memory.getId());
entityManager.flush();
entityManager.clear();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ void findAllByMemory_MemoryMembers_Member() {

@DisplayName("특정 추억의 id를 가진 모든 스타카토를 삭제한다.")
@Test
void deleteAllByMemoryIdInBatch() {
void deleteAllByMemoryIdInBulk() {
// given
Member member = memberRepository.save(MemberFixture.create());
Memory memory = memoryRepository.save(MemoryFixture.create(LocalDate.of(2023, 12, 31), LocalDate.of(2024, 1, 10)));
Expand All @@ -81,7 +81,7 @@ void deleteAllByMemoryIdInBatch() {
Moment moment2 = momentRepository.save(MomentFixture.create(memory, LocalDateTime.of(2024, 1, 1, 22, 21)));

// when
momentRepository.deleteAllByMemoryIdInBatch(memory.getId());
momentRepository.deleteAllByMemoryIdInBulk(memory.getId());
entityManager.flush();
entityManager.clear();

Expand Down

0 comments on commit 7c66f2d

Please sign in to comment.