-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[로또] 정하림 미션 제출합니다. #94
Open
jbrunoo
wants to merge
21
commits into
woowacourse-precourse:main
Choose a base branch
from
jbrunoo:jbrunoo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
금액, 당첨 번호, 보너스 번호 입력 null 처리
공통 : 정수 판별 1. 구입 금액 (1000-100000 범위) 2. 당첨 번호 리스트 (1-45 범위, 개수 6, 중복 체크) 3. 보너스 번호 (1-45 범위) 테스트 코드 추가 완료
Validator, Lotto, stringExtension 분리 각 클래스 테스트 코드 작성
Constants, Exceptions 분리 (입력 메시지, 매직 넘버, 구분자, 예외 메시지) commit 3개 rebase
투 포인터를 활용한 리스트 중복 값 비교 보너스 숫자 포함 비교
runCatching으로 처리한 부분이 해결되지 않아서 inputView에서 입력 값 수정 추후 리팩토링 예정
매칭 숫자 계산 수익률 계산
당첨 통계에 필요한 문자열 포맷 기능 추가
style, 상수화
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.