normalizes setScope(string) to be case unsensitive (#68)

wooga · Jan 15, 2024 · 4af1c91 · 4af1c91
1 parent 5925b36
commit 4af1c91
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...tegrationTest/groovy/wooga/gradle/version/VersionPluginMultiProjectIntegrationSpec.groovy b/...tegrationTest/groovy/wooga/gradle/version/VersionPluginMultiProjectIntegrationSpec.groovy
@@ -53,7 +53,7 @@ class VersionPluginMultiProjectIntegrationSpec extends VersionIntegrationSpec {
                     ${applyPlugin(VersionPlugin)}
                     versionBuilder.prefix = ${wrapValueBasedOnType(it.prefix, String)}
                     versionBuilder.stage.set(${wrapValueBasedOnType(it.stage, String)})
-                    versionBuilder.scope = provider{ ${wrapValueBasedOnType(it.scope, "ChangeScope")} }
+                    versionBuilder.scope = ${wrapValueBasedOnType(it.scope, String)}
                     versionBuilder.versionScheme = ${wrapValueBasedOnType(it.versionScheme, String)}
                     versionBuilder.versionCodeScheme = ${wrapValueBasedOnType(it.versionCodeScheme, String)}
 
@@ -87,7 +87,7 @@ class VersionPluginMultiProjectIntegrationSpec extends VersionIntegrationSpec {
                 prefix: "proj1-",
                 nearestNormal: "0.0.1",
                 stage: "final",
-                scope: ChangeScope.MINOR,
+                scope: "MINOR",
                 versionScheme: "semver",
                 versionCodeScheme: VersionCodeSchemes.releaseCountBasic,
                 newVersion: "0.1.0",
@@ -99,7 +99,7 @@ class VersionPluginMultiProjectIntegrationSpec extends VersionIntegrationSpec {
                 prefix: "proj2-",
                 nearestNormal: "1.0.0",
                 stage: "rc",
-                scope: ChangeScope.MAJOR,
+                scope: 'major',
                 versionScheme: "semver2",
                 versionCodeScheme: VersionCodeSchemes.semver,
                 newVersion: "2.0.0-rc.1",

diff --git a/src/main/groovy/wooga/gradle/version/VersionPluginExtension.groovy b/src/main/groovy/wooga/gradle/version/VersionPluginExtension.groovy
@@ -251,7 +251,7 @@ trait VersionPluginExtension implements BaseSpec {
     }
 
     void setScope(String scope) {
-        this.scope.set(ChangeScope.valueOf(scope.trim()))
+        this.scope.set(ChangeScope.valueOf(scope.trim().toUpperCase()))
     }
 
     private final Property<String> prefix = objects.property(String)