Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Commit

Permalink
Remove coveralls reporting (#313)
Browse files Browse the repository at this point in the history
Description
===========

Because of security issues reported for the
coveralls gradle plugin I decided to remove the feature
during build. It is not enough to just stop sending
reports via jenkins. We also need to update to
`net.wooga.plugins` > `4.0.0` because this version removes
the dependency.

I remove the coveralls token in the Jenkinsfile so
our base pipeline won't try to call the coveralls task
on the gradle project.

Changes
=======

* ![UPDATE] `net.wooga.plugins` to version `4.0.0` to remove coveralls dependency
* ![REMOVE] coveralls token in Jenkinsfile
  • Loading branch information
Larusso authored May 11, 2022
1 parent 107a552 commit 9d6bb3b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,13 @@
@Library('github.com/wooga/[email protected]') _

withCredentials([
string(credentialsId: 'atlas_secrets_coveralls_token', variable: 'coveralls_token'),
string(credentialsId: 'aws.secretsmanager.integration.accesskey', variable: 'accesskey'),
string(credentialsId: 'aws.secretsmanager.integration.secretkey', variable: 'secretkey'),
string(credentialsId: 'atlas_plugins_sonar_token', variable: 'sonar_token'),
string(credentialsId: 'atlas_plugins_snyk_token', variable: 'SNYK_TOKEN')
])
{
def env = ["ATLAS_AWS_INTEGRATION_ACCESS_KEY=${accesskey}", "ATLAS_AWS_INTEGRATION_SECRET_KEY=${secretkey}"]
buildGradlePlugin platforms: ['macos','windows', 'linux'], coverallsToken: coveralls_token, sonarToken: sonar_token, testEnvironment:env
buildGradlePlugin platforms: ['macos','windows', 'linux'], sonarToken: sonar_token, testEnvironment:env
}

2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

plugins {
id 'net.wooga.plugins' version '3.2.0'
id 'net.wooga.plugins' version '4.0.0'
id 'net.wooga.snyk' version '0.10.0'
id "net.wooga.snyk-gradle-plugin" version "0.2.0"
id "net.wooga.cve-dependency-resolution" version "0.4.0"
Expand Down

0 comments on commit 9d6bb3b

Please sign in to comment.