py3-awscrt/0.23.4 package update

[octo-sts]

[octo-sts]

Gen AI suggestions to solve the build error:

Based on the error output and context provided, here's my analysis:

• Detected Error: The error appears to be in the git checkout step, specifically with submodule initialization. While not explicitly shown in the error, this is inferred from the context and the manual s2n update step in the pipeline.

• Error Category: Version/Configuration

• Failure Point: Git checkout step with submodules

• Root Cause Analysis: The current pipeline is trying to update s2n manually after checkout, but this approach may be causing conflicts with the submodule initialization process.

• Suggested Fix:

1. Remove the manual s2n update step and instead use the sparse-checkout feature in the git-checkout pipeline:

pipeline:
  - uses: git-checkout
    with:
      repository: https://github.com/awslabs/aws-crt-python
      tag: v${{package.version}}
      expected-commit: 4742211db7e3e9c8903b7659389aca8b08ade4ce
      recurse-submodules: true
      submodule-update: true
      submodule-override:
        crt/s2n: 
          repository: https://github.com/aws/s2n-tls
          ref: 1.5.9

• Explanation:

• The current approach of manually updating s2n after checkout can lead to inconsistencies
• Using submodule-override provides a cleaner way to specify exact versions of submodules
• This ensures all dependencies are in sync during the build process
• Version 1.5.9 of s2n-tls is known to be compatible and includes the necessary fixes

• Additional Notes:

• The package is using system libcrypto (AWS_CRT_BUILD_USE_SYSTEM_LIBCRYPTO=1) which is correct
• The current s2n-tls package in the build environment is version 1.5.9-r0
• This approach maintains better dependency tracking and reproducibility

• References:

• s2n-tls releases: https://github.com/aws/s2n-tls/releases
• Related issue: 0.15.1: build fails with implicit declaration of function ‘s2n_cleanup_final’ awslabs/aws-c-io#688

[octo-sts]

Gen AI suggestions to solve the build error:

• Detected Error: IndentationError: expected an indented block after 'if' statement on line 351

• Error Category: Build Configuration

• Failure Point: Python setup.py during pip wheel build step

• Root Cause Analysis:
The sed command that modifies setup.py has introduced an indentation error by removing lines without properly maintaining Python's indentation structure. The if statement at line 351 is left without its required indented block.

• Suggested Fix:
Modify the sed command in the pipeline to preserve proper indentation:

- runs: |
    # Allow linking to shared libraries
    sed -i.dist '/libraries = \[/,/libraries\]/{/^[[:space:]]*libraries = \[/!{/^[[:space:]]*\]/!d}}' setup.py
    diff -u setup.py.dist setup.py &&
        { echo "attempted change to setup.py did nothing"; exit 1; }

Or alternatively, use a more targeted approach:

- runs: |
    # Allow linking to shared libraries
    sed -i.dist 's/libraries = \[.*\]/libraries = libraries/' setup.py
    diff -u setup.py.dist setup.py &&
        { echo "attempted change to setup.py did nothing"; exit 1; }

• Explanation:
The current sed command is removing lines related to library linking but breaking the Python code structure. The suggested fix maintains proper indentation while removing the static library configuration, allowing the code to compile correctly.

• Additional Notes:

• The original code block is attempting to handle static vs. shared library linking
• The modification needs to preserve Python's strict indentation requirements
• This change maintains the intended functionality while fixing the syntax error

• References:

• AWS CRT Python build documentation: https://github.com/awslabs/aws-crt-python#building
• Related issue about library linking: 0.15.1: build fails with implicit declaration of function ‘s2n_cleanup_final’ awslabs/aws-c-io#688