Accessibility: Button pressed state and lists #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
dc4fd25 to
a8c5ad5
Compare
|
@wojtekmaj Is there anything else you need from me to make this happen? |
tskarhed
commented
Sep 4, 2024
tskarhed
commented
Sep 5, 2024
| @@ -120,6 +120,7 @@ export default function Tile(props: TileProps): React.ReactElement { | |||
| onMouseOver={onMouseOver ? () => onMouseOver(date) : undefined} | |||
| style={style} | |||
| type="button" | |||
| aria-pressed={!!classes?.find((classString) => classString.indexOf('--active') != -1 || classString.indexOf('--hasActive') != -1)} | |||
There was a problem hiding this comment.
This is the easiest way I could figure out how to check for the selected state.
|
hi @wojtekmaj I'm interested in the status of this PR as well. The issue that this PR is fixing blocks my ability to use the library in a project. Is this something that's intended to be merged in the near future? |
|
I, too, am interested in this fix. |
|
@wojtekmaj I am not quite sure how these changes are affecting the failing tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #613 by adding a pressed state to the button.
Also adds lists for displaying, so a screen reader may know which item number you are currently at.
Preferably it would use tables and support arrow key navigation, as mentioned in #887, but that requires quite a lot of refactoring which will result in breaking changes.