Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional bundle options to be set during build #15

Merged
merged 2 commits into from
Sep 30, 2021

Conversation

paulhoadley
Copy link
Contributor

It's currently quite tricky to get certain JVM options set at application launch time. The launch script does some gymnastics to get JVM options into the right place on the command line: those starting with -X, for example, end up in the right place (that is, prior to the class name). But some, like the old -server and newer --add-exports are not moved into the right place by the launch script. The launch script will honour the JVMOptions line in the header of the *ClassPath.txt files, but there's currently no mechanism for setting this using wolifecycle-maven-plugin.

So, all this pull request does is to update wolifecycle.build.xml to set the following when the woapplication Ant task builds the bundle:

  • jvm
  • jvmOptions
  • jdb
  • jdbOptions

Their values are pulled from properties of the same names, so you can set them in build.properties:

jvm=foo
jvmOptions=bar
jdb=bar
jdbOptions=quux

Specifically, adds the following:

* jvm
* jvmOptions
* jdb
* jdbOptions

These can now all be specified in build.properties.
@maiksd maiksd merged commit 76290ed into wocommunity:master Sep 30, 2021
@hprange hprange added this to the 2.5 milestone Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants