Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use thread_local instead of (deprecated) JsStatic #8

Conversation

maxime-tournier
Copy link

Hello there,

I tried compiling your crate with a recent rust nightly, which ended up in compilation errors.

I could fix them using thread_local instead of JsStatic (as per https://rustwasm.github.io/wasm-bindgen/reference/static-js-objects.html), hence this PR.

Please let me know if this seems reasonable to you?

@wngr wngr merged commit c7a8b3e into wngr:master Oct 3, 2024
1 check failed
@wngr
Copy link
Owner

wngr commented Oct 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants