-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI and styling update? #34
base: master
Are you sure you want to change the base?
Conversation
Change: Background Text font Add tailwindcss This is WIP
Add ability to toggle on and off warning label
Change styling in index.htm to match those in v2.
We've had a talk with @lost-hope about changing installer look to introduce step-by-step selection of:
Could you tackle this? |
The design rework (this PR) looks fine to me.
I have a proof of concept ot this, but havent found a satisfying way to have the manifest file string generated with the user inputs. |
Just a small fix where the board option would still be displayed even though they were not supported
@LucasoDevDotTk instead of just committing, please provide a requested feedback. |
Oh sorry, my bad, I have messaged Soren on discord and are discussing what the best solution may be. Not the best at developing things related to ioT, but I can certainly attempt. I just need a pretty detailed description of what the correct implementation would be. I have sent a suggestion to Soren about what I think may be a good idea. |
This is my idea: The first thing that popped into my mind was: On commit marked with a special tag or part in the name: run a github action python script that parses and generates a versions.json in ./, and commit that to the repo. The python/shell script can easily be made by using CSV parsers. For example:
Where the However I dont know if this a viable option? This way, when a new version releases, the only thing you or other maintainers need to do, is to push a commit with the files to the /bin directory and the gh action will do the rest (As long as the file name is made correctly). Of course, we can also make a gh test that checks with a regex if everything matches the right pattern. |
Ok, sorry, didn't know you are already talking to @lost-hope . |
Hi there!
I've been using WLED for a while and thought I'd contribute. Below are the details of my suggestion:
Description:
Testing:
Visual Changes:
I've included images to showcase the changes:
Additional Notes:
The background color can be reverted to the original if needed.