API updates #49
Merged
API updates #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabaldon
force-pushed
the
test-api-updates-2
branch
2 times, most recently
from
3e0f896 to
65664f0
Compare
parodyBit
requested changes
Feb 15, 2024
gabaldon
force-pushed
the
test-api-updates-2
branch
from
7f27037 to
007bfda
Compare
gabaldon
force-pushed
the
test-api-updates-2
branch
from
0f9814c to
d9d015d
Compare
gabaldon
force-pushed
the
test-api-updates-2
branch
3 times, most recently
from
beb6fcd to
387365a
Compare
gabaldon
force-pushed
the
test-api-updates-2
branch
from
387365a to
eec0b6a
Compare
parodyBit
approved these changes
Feb 20, 2024
| String toRawJson() => json.encode(jsonMap()); | ||
|
|
||
| factory NetworkBalances.fromJson(Map<String, dynamic> json) => | ||
| NetworkBalances( |
There was a problem hiding this comment.
Suggested change
| NetworkBalances( | |
| NetworkBalances( | |
| balances: List<Balance>.from(json["balances"].map((e) => Balance.fromJson(e))), | |
| totalItems: json["total_items"], | |
| totalBalancesSum: json["total_balance_sum"], | |
| lastUpdated: json["last_updated"], | |
| ); |
| "balances": balances.map((e) => e.jsonMap()), | ||
| "total_items": totalItems, | ||
| "total_balances_sum": totalBalancesSum, | ||
| "lastUpdated": lastUpdated, |
There was a problem hiding this comment.
Suggested change
| "lastUpdated": lastUpdated, | |
| "last_updated": lastUpdated, |
| Balance({ | ||
| required this.address, | ||
| required this.balance, | ||
| required this.level, |
There was a problem hiding this comment.
the variable is label, and needs to be updated in the json methods as well
Suggested change
| required this.level, | |
| required this.label, |
|
|
||
| factory NetworkReputation.fromJson(Map<String, dynamic> json) => | ||
| NetworkReputation( | ||
| reputations: json["reputation"].map((e) => Reputation.fromJson(e)), |
There was a problem hiding this comment.
Suggested change
| reputations: json["reputation"].map((e) => Reputation.fromJson(e)), | |
| reputations: List<Reputation>.from(json["reputation"].map((e) => Reputation.fromJson(e))), |
| factory Reputation.fromJson(Map<String, dynamic> json) => Reputation( | ||
| address: json["address"], | ||
| reputation: json["reputation"], | ||
| eligibility: json["eligility"], |
There was a problem hiding this comment.
Suggested change
| eligibility: json["eligility"], | |
| eligibility: json["eligibility"], |
| final List<BlockchainInfo> blockchain; | ||
|
|
||
| factory Blockchain.fromJson(Map<String, dynamic> data) { | ||
| return Blockchain( | ||
| blockchain: List<BlockchainInfo>.from( | ||
| data['blockchain'].map((e) => BlockchainInfo.fromList(e)))); | ||
| data['blockchain'].map((e) => BlockchainInfo.fromJson(e))), | ||
| reverted: data["reverted"], |
There was a problem hiding this comment.
Suggested change
| reverted: data["reverted"], | |
| reverted: List<int>.from(data["reverted"]), |
| try { | ||
| return Status.fromJson(await client.get(api('status'))); | ||
| PaginatedRequest<dynamic> result = await client.get( |
There was a problem hiding this comment.
The reputation endpoint is not Paginated
https://witscan.xyz/api/documentation#get-/api/network/reputation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #51