Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Dot Case & Shouty Dot Case #44

Closed
wants to merge 6 commits into from

Conversation

kensj
Copy link

@kensj kensj commented Jul 22, 2023

Adding support for Dot Case & Shouty Dot Case.

Open to naming suggestions.

Take the following strings as an example:

  • dot.case
  • SHOUTY.DOT.CASE

@kensj
Copy link
Author

kensj commented Jul 29, 2023

Hey @jplatte @withoutboats, lmk if this looks good. Currently working off a fork, helpful for my use case.
Thanks!

@jplatte
Copy link
Collaborator

jplatte commented Aug 14, 2023

Please, when you want to contribute to a project, check with the maintainers before putting in the work. It's not a nice experience for anybody involved when a PR gets rejected. Anyways, given we're in this situation already..

What's the use case for this?

@kensj
Copy link
Author

kensj commented Aug 15, 2023

Please, when you want to contribute to a project, check with the maintainers before putting in the work. It's not a nice experience for anybody involved when a PR gets rejected. Anyways, given we're in this situation already..

This was very quick code I wrote for my use case. Since I had it working off a fork, I made this PR for anyone else who may find it helpful. If you don't see the value in it, then I can continue working off the fork for my use case.

What's the use case for this?

I needed this to match string values coming in from external webhooks that are formatted in dot case.

@jplatte
Copy link
Collaborator

jplatte commented Aug 15, 2023

I don't fully understand but I think this kind of use case should not be solved by this library by adding ever more casing conventions with names made up on the spot. Maybe there will be an API for "custom" casing conventions at some point though (c.f. #6).

@jplatte jplatte closed this Aug 15, 2023
@kensj
Copy link
Author

kensj commented Aug 15, 2023

Fair enough. I will mention that it is odd that it's not included as a convention as you may find this in many places.

image

I will continue working off my fork.

@jplatte
Copy link
Collaborator

jplatte commented Aug 15, 2023

Well, I hadn't seen it before. What's that screenshot from?

@jplatte jplatte mentioned this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants