Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse order of styles & scripts #1055

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Reverse order of styles & scripts #1055

wants to merge 5 commits into from
+35 −10

Conversation

TheOtterlord
Copy link
Member

Changes

Testing

  • Updated existing styles test
  • Added test for scripts order

Docs

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 88aa209

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

MoustaphaDev
MoustaphaDev reviewed Jan 2, 2025
View reviewed changes
Copy link
Member

@MoustaphaDev MoustaphaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, I just have a suggestion on a test

packages/compiler/test/scripts/order.ts Outdated Show resolved Hide resolved
@MoustaphaDev
Copy link
Member

MoustaphaDev commented Jan 3, 2025 •
edited
Loading

Not sure why the go lint job is failing, but for the js one, running pnpm check:writeshould be able to fix it.

@TheOtterlord
Copy link
Member Author

It's also failing on main, so probably worth a separate PR

@TheOtterlord
Copy link
Member Author

ohh, only lint fails on main. I'll fix the js one now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoustaphaDev MoustaphaDev MoustaphaDev approved these changes

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Astro reverses the order of <style> tags in a page/component
3 participants
@TheOtterlord @MoustaphaDev @ematipico