Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "feat(server-islands): only encode ETAGO delimiter (#11513)"" #13031

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Jan 21, 2025

Brings back #11513

Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: eb065dd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 21, 2025
@florian-lefebvre florian-lefebvre marked this pull request as ready for review January 21, 2025 13:48
@ematipico
Copy link
Member

I miss some context. Can you provide some?

Copy link

codspeed-hq bot commented Jan 21, 2025

CodSpeed Performance Report

Merging #13031 will not alter performance

Comparing revert-13013-revert-etago (eb065dd) with main (8911bda)

Summary

✅ 6 untouched benchmarks

@florian-lefebvre
Copy link
Member Author

Yes! The original PR works well, but when we merged it it caused tests to fail on main. That's because I didn't merge main into the branch before merging, so there was a conflict between 2 tests. It's now resolved, I checked locally. Now waiting for the tests to pass here

@florian-lefebvre florian-lefebvre merged commit f576519 into main Jan 21, 2025
16 checks passed
@florian-lefebvre florian-lefebvre deleted the revert-13013-revert-etago branch January 21, 2025 14:09
@astrobot-houston astrobot-houston mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants