Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): add Starlog example viewport meta tag #12941

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

codenomnom
Copy link
Contributor

Changes

The Starlog example was missing a viewport meta tag, which was causing issues on mobile devices (media queries not working properly):

image

Adding a default one fixes the issue:

image

Note: I haven't included achangeset as it was said they're not needed for examples.

Testing

By emulating mobile device on Chrome (Toggle device toolbar in dev tools) and on a personal website 🙂
No tests added as this is an example template.

Docs

No updates or changes required - it affects only Starlog example users on mobile devices.

Copy link

changeset-bot bot commented Jan 8, 2025

⚠️ No Changeset found

Latest commit: 014f602

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Jan 8, 2025
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ascorbic ascorbic merged commit bbb1bc9 into withastro:main Jan 9, 2025
15 checks passed
@codenomnom codenomnom deleted the fix/starlog-example-viewport branch January 9, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants