Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): add node types dep #12905

Merged
merged 1 commit into from
Jan 6, 2025
Merged

chore(examples): add node types dep #12905

merged 1 commit into from
Jan 6, 2025

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Jan 6, 2025

Changes

Adds @types/node to the toolbar app example, because it uses tsc

Fixes #12903

Testing

Docs

Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: 1e365e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Jan 6, 2025
@Princesseuh
Copy link
Member

I wonder what happened, I fixed this already some time ago #12519

@ascorbic
Copy link
Contributor Author

ascorbic commented Jan 6, 2025

wtf I can't see that commit in the history at all! https://github.com/withastro/astro/commits/main/examples/toolbar-app/package.json

@ascorbic ascorbic merged commit 383c2ab into main Jan 6, 2025
15 checks passed
@ascorbic ascorbic deleted the examples-node-peer branch January 6, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astro Starter Kit: Toolbar App | Cannot find module 'node:url' or its corresponding type declarations.
3 participants