feat(fonts): config #12777
Merged
feat(fonts): config #12777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
pkg: astro
This comment was marked as outdated.
This comment was marked as outdated.
ematipico
requested changes
Jan 21, 2025
|
|
||
| export interface FontProvider<TName extends string> { | ||
| name: TName; | ||
| entrypoint: string; |
There was a problem hiding this comment.
entrypoint should be a string or a URL. Since v5, all entry points now accept URL too
There was a problem hiding this comment.
I'll address this in the next PR
| export function adobe(config: { apiKey: string }) { | ||
| return defineFontProvider({ | ||
| name: 'adobe', | ||
| entrypoint: 'astro/assets/fonts/providers/adobe', |
There was a problem hiding this comment.
Entrypoints should have the file extension. E.g. astro/assets/fonts/providers/adobe.js
ematipico
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Adds some types and config tests
Docs
N/A