fix(perf): do not await in for loop to enqueue asset transforms. F…

…ixes #12845
withastro · Jan 7, 2025 · 3959913 · 3959913
1 parent 8b9d530
commit 3959913
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/new-radios-pay.md b/.changeset/new-radios-pay.md
@@ -0,0 +1,7 @@
+---
+'astro': patch
+---
+
+Improve static asset generation performance by removing the `await` in the `for` loop. This change will allow the p-queue concurrency to limit the number of parallel tasks. Previously, the `await` in the `for` loop would cause all asset generation tasks to run serially.
+
+Fixes #12845
diff --git a/packages/astro/src/core/build/generate.ts b/packages/astro/src/core/build/generate.ts
@@ -125,7 +125,7 @@ export async function generatePages(options: StaticBuildOptions, internals: Buil
 
 		const assetsTimer = performance.now();
 		for (const [originalPath, transforms] of staticImageList) {
-			await generateImagesForPath(originalPath, transforms, assetsCreationPipeline, queue);
+			generateImagesForPath(originalPath, transforms, assetsCreationPipeline, queue);
 		}
 
 		await queue.onIdle();