Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow number/normal to be used as a method type #977

Merged
merged 1 commit into from
Oct 2, 2015
Merged

Allow number/normal to be used as a method type #977

merged 1 commit into from
Oct 2, 2015

Conversation

bigdogmat
Copy link
Member

Fixes #934

@Divran
Copy link
Contributor

Divran commented Oct 1, 2015

fine by me
@Nebual @AbigailBuccaneer @TomyLobo @syranide

@Nebual
Copy link
Member

Nebual commented Oct 1, 2015

If it works, sure. I'd prefer to know why it was disabled in the first place though.

@Divran
Copy link
Contributor

Divran commented Oct 2, 2015

Because syranide wanted it to be (read the issue bigdogmat linked to see syranide's reply)

@syranide
Copy link
Member

syranide commented Oct 2, 2015

rabble rabble rabble 👍

@thegrb93
Copy link
Contributor

thegrb93 commented Oct 2, 2015

You sure it wasn't put in place to stop some sort of exploit? Just checking.

AbigailBuccaneer added a commit that referenced this pull request Oct 2, 2015
Allow number/normal to be used as a method type
@AbigailBuccaneer AbigailBuccaneer merged commit 2a6738f into wiremod:master Oct 2, 2015
@TomyLobo
Copy link
Contributor

TomyLobo commented Oct 7, 2015

@thegrb93 seems unlikely. how would that work?

@thegrb93
Copy link
Contributor

thegrb93 commented Oct 7, 2015

I don't know anything about the internals of e2, but usually a feature is excluded like that if there is a problem with it, but Idk.

@brandonsturgeon
Copy link
Contributor

Ship it! See if things break.

@AbigailBuccaneer
Copy link
Contributor

@brandonsturgeon already shipped. I decided @thegrb93 was just talking nonsense and so ignored them :)

@thegrb93
Copy link
Contributor

thegrb93 commented Oct 7, 2015

I'm not talking nonsense. Features are commonly disabled like that due to a problem.

@syranide
Copy link
Member

syranide commented Oct 7, 2015

@thegrb93 #934 (comment)

@thegrb93
Copy link
Contributor

thegrb93 commented Oct 7, 2015

"I can't imagine it being there for any other reason" doesn't sound very convincing, but if you guys tested it and there's no obvious exploits then okay.

@Divran
Copy link
Contributor

Divran commented Oct 7, 2015

why are you talking about this. Syranide already confirmed that it was
disabled because he wanted it to be. No other reason. It's not broken.

On Wed, Oct 7, 2015 at 6:15 PM, thegrb93 [email protected] wrote:

"I can't imagine it being there for any other reason" doesn't sound very
convincing, but if you guys tested it and there's no obvious exploits then
okay.


Reply to this email directly or view it on GitHub
#977 (comment).

@thegrb93
Copy link
Contributor

thegrb93 commented Oct 8, 2015

Because I'm concerned about the safety of my server as anyone should be.

@syranide
Copy link
Member

syranide commented Oct 8, 2015

In the end it's just another (special) parameter, so other than parsing issues there's nothing to worry about.

@immibis
Copy link
Contributor

immibis commented Oct 24, 2015

Can we rename normal to number everywhere yet?

@TomyLobo
Copy link
Contributor

"everywhere" would include code beyond our control

@bigdogmat bigdogmat deleted the patch-1 branch November 26, 2015 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants