Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix add bots to conversations #4423

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −3
Draft

fix add bots to conversations #4423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53a9b6b
fix add bots to conversations
stefanwire Jan 27, 2025
59357f7
fix path
mastaab Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/nginz/static/conf/zauth.acl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
a (blacklist (regex "(/v[0-9]+)?/provider(/.*)?")
(regex "(/v[0-9]+)?/bot(/.*)?")
(regex "(/v[0-9]+)?/bot(/(?!conversations/.+).*)?")
(regex "(/v[0-9]+)?/i/.*"))

b (whitelist (regex "(/v[0-9]+)?/bot(/.*)?"))
b (whitelist (regex "(/v[0-9]+)?/bot(/(?!conversations/.+).*)?"))

p (whitelist (regex "(/v[0-9]+)?/provider(/.*)?"))

Expand Down
5 changes: 4 additions & 1 deletion charts/nginz/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,9 @@ nginx_conf:
- path: /upgrade-personal-to-team$
envs:
- all
- path: /bot/conversations/(.+)
envs:
- all
galley:
- path: /conversations/code-check
disable_zauth: true
Expand Down Expand Up @@ -503,7 +506,7 @@ nginx_conf:
- all
max_body_size: 40m
body_buffer_size: 256k
- path: /bot/conversation
- path: /bot/conversation$
envs:
- all
- path: /bot/messages
Expand Down
Loading