feat: authentication flow views - On premise - WPB-15225 #2531
Conversation
…o feat/authentication-on-premise-WPB-15225
…o feat/authentication-on-premise-WPB-15225
Test Results32 tests 32 ✅ 9s ⏱️ Results for commit 504cbb4. ♻️ This comment has been updated with latest results. |
|
|
||
| import Foundation | ||
|
|
||
| public struct BackendEnvironment { |
There was a problem hiding this comment.
@johnxnguyen I'm not sure where we should define BackendEnvironment, since we have it in WireAPI too
There was a problem hiding this comment.
I think we should use the one defined in WireAPI rather than duplicating it. Did you try it?
| }, label: { | ||
| Text(L10n.OnPremUserLogin.title(viewModel.backendName) + " ") | ||
| .foregroundColor(ColorTheme.Buttons.Secondary.onEnabled.color) | ||
| + Text(Image(systemName: "info.circle")) |
There was a problem hiding this comment.
I'm struggling to fix this SwiftFormat issue
| @State private var showPasswordRules: Bool = false | ||
| @State private var showCustomBackendAlert = false | ||
|
|
||
| private var proxyEmail: String = "" |
There was a problem hiding this comment.
question: shouldn't this also be @State?
|
|
||
| @ViewBuilder private var submitButton: some View { | ||
| Button(action: { | ||
| viewModel.submitPassword(password) |
There was a problem hiding this comment.
I would expect that we submit not only the account password but also the proxy credentials it there are any.
…o feat/authentication-on-premise-WPB-15225
Datadog ReportBranch report: ✅ 0 Failed, 27 Passed, 0 Skipped, 9.57s Total Time |
There was a problem hiding this comment.
The heights of the text fields doesn't look right.
Probably @ScaledMetric shouldn't be used.
Issue
Implement new authentication flow views -> Login -> On premise:
Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: