-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wire cells upload preview documents - WPB-15843 #2528
base: develop
Are you sure you want to change the base?
Conversation
Test Results 1 files 10 suites 42s ⏱️ Results for commit cc80e1b. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 84 Passed, 1 Skipped, 23.98s Total Time |
75fecbe
to
cc80e1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this is based on the other pr #2513.
- Could you point to it to have only the relevent changes?
- Following the figma in the ticket I couldn't see the reference.
Should display the file type icon, file type, file size, file name, upload progress bar, and a “x” icon to delete.
I don't see in the snapshot the icon or filetype
import WireFoundation | ||
import WireReusableUIComponents | ||
|
||
struct UploadDocumentPreview: View { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is the only file that change compared to https://github.com/wireapp/wire-ios/pull/2513/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. That and the tests.
No. Because then I’ll also have to repoint it over again once the other PR is merged. I’d much rather we merge the base branch.
The fields are there. They don’t care about the specific icon or file type. Those are to be provided to the view when it is created. |
Issue
Implements upload previews layout for document (WPB-15844).
Accessibility labels will be added when available.
Testing
See UI Tests snapshots.
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: