Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wire cells upload preview documents - WPB-15843 #2528

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

El-Fitz
Copy link
Contributor

@El-Fitz El-Fitz commented Feb 12, 2025

TaskWPB-15843 [iOS] Create upload preview component for non-media files (.zip, .pdf, .doc, .docx, .csv, etc)

Issue

Implements upload previews layout for document (WPB-15844).
Accessibility labels will be added when available.

Testing

See UI Tests snapshots.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.

@El-Fitz El-Fitz self-assigned this Feb 12, 2025
Copy link
Contributor

github-actions bot commented Feb 12, 2025

Test Results

  1 files   10 suites   42s ⏱️
111 tests 110 ✅ 1 💤 0 ❌
112 runs  111 ✅ 1 💤 0 ❌

Results for commit cc80e1b.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 12, 2025

Datadog Report

Branch report: feat/wire-cells-upload-preview-pdfs
Commit report: a614b12
Test service: wire-ios-mono

✅ 0 Failed, 84 Passed, 1 Skipped, 23.98s Total Time

@El-Fitz El-Fitz force-pushed the feat/wire-cells-upload-preview-pdfs branch from 75fecbe to cc80e1b Compare February 12, 2025 16:12
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this is based on the other pr #2513.

  1. Could you point to it to have only the relevent changes?
  2. Following the figma in the ticket I couldn't see the reference.

Should display the file type icon, file type, file size, file name, upload progress bar, and a “x” icon to delete.

I don't see in the snapshot the icon or filetype

import WireFoundation
import WireReusableUIComponents

struct UploadDocumentPreview: View {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is the only file that change compared to https://github.com/wireapp/wire-ios/pull/2513/files

Copy link
Contributor Author

@El-Fitz El-Fitz Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That and the tests.

@El-Fitz
Copy link
Contributor Author

El-Fitz commented Feb 12, 2025

  1. Could you point to it to have only the relevent changes?

No. Because then I’ll also have to repoint it over again once the other PR is merged. I’d much rather we merge the base branch.

  1. Following the figma in the ticket I couldn't see the reference.

Should display the file type icon, file type, file size, file name, upload progress bar, and a “x” icon to delete.

I don't see in the snapshot the icon or filetype

The fields are there. They don’t care about the specific icon or file type. Those are to be provided to the view when it is created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants