fix: Proteus messages not being sent anymore - WPB-16067 #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jullianm
requested review from
a team,
netbe,
samwyndham and
KaterinaWire
and removed request for
a team
netbe
reviewed
Feb 12, 2025
Test Results281 tests 281 ✅ 7s ⏱️ Results for commit c84d7d6. ♻️ This comment has been updated with latest results. |
caldrian
reviewed
Feb 12, 2025
caldrian
approved these changes
Feb 12, 2025
netbe
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Context: Proteus messages are not sent anymore on 3.118
Cause: we use the legacy Cryptobox instead of CC because of proteusViaCoreCrypto returning false: plist we use to retrieve the flag value (set to true) was removed in previous PR.
Solution: add the config value back to plist
Testing
Proteus messages sending should behave normally
Checklist
[WPB-XXX].