Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: preparations for universal backup/restore - WPB-14616 #2523

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


EpicWPB-14616 [iOS] Prepare for universal backups

Issue

This PR removes the button (and a lot of code) for restoring a backup in the authentication flow.
Also the settings page for creating a backup has been replaced by a new one allowing backup and restore.
Backup passwords are optional now.

Testing

Create and restore backups.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

Co-authored-by: KaterinaWire <[email protected]>
Co-authored-by: Christoph Aldrian <[email protected]>
Co-authored-by: Christoph Aldrian <[email protected]>
Co-authored-by: Jullian Mercier <[email protected]>
@caldrian caldrian enabled auto-merge February 12, 2025 10:58
Copy link
Contributor Author

Test Results

   10 files     20 suites   12m 1s ⏱️
7 192 tests 7 160 ✅ 32 💤 0 ❌
7 203 runs  7 171 ✅ 32 💤 0 ❌

Results for commit bcc812a.

@datadog-wireapp
Copy link

Datadog Report

Branch report: epic/prepare-for-universal-backups-WPB-14616-cherry-pick
Commit report: d540666
Test service: wire-ios-mono

✅ 0 Failed, 6845 Passed, 32 Skipped, 5m 1.99s Total Time

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍒

@caldrian caldrian added this pull request to the merge queue Feb 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2025
@caldrian caldrian added this pull request to the merge queue Feb 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2025
@netbe netbe added this pull request to the merge queue Feb 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants